Closed Jap8nted closed 1 year ago
Thanks. I'll leave it to @ianthomas23 to think about whether it's appropriate to raise an error or to return an empty array in this case; not sure which is e.g. less problematic for HoloViews.
OK, so the options here are
I'd be happy with either but my preference is for 1 as I'd rather detect the situation as soon as possible and report it immediately.
@Jap8nted Are you happy to continue with this PR?
If so, this fix is good, it is failing CI because the raised ValueError
doesn't need to use an f-string. Also, it should have a test to confirm that the fix is good. A new test in test_pandas.py
should suffice, perhaps just below test_line_coordinate_lengths
and it can use similar pytest.raises
logic to that test.
Hi,
I will continue with it, @ianthomas23.
In my opinion, raising an error is better as we skip unnecessary calculations.
will fix it later and check that the CI finishes successfully.
Merging #1183 (51e7f18) into main (198c0b4) will increase coverage by
0.00%
. The diff coverage is100.00%
.:exclamation: Current head 51e7f18 differs from pull request most recent head 58178ca. Consider uploading reports for the commit 58178ca to get more accurate results
@@ Coverage Diff @@
## main #1183 +/- ##
=======================================
Coverage 85.38% 85.39%
=======================================
Files 35 35
Lines 8011 8016 +5
=======================================
+ Hits 6840 6845 +5
Misses 1171 1171
Impacted Files | Coverage Δ | |
---|---|---|
datashader/core.py | 88.35% <100.00%> (+0.09%) |
:arrow_up: |
datashader/transfer_functions/__init__.py | 86.91% <0.00%> (+0.02%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Thanks for the comments and help @ianthomas23 and happy to help!
See issue https://github.com/holoviz/datashader/issues/1141.
When a canvas is created with plot_width=0 or plot_height=0 and the data is coming from dask, there is a core dump error, up to now, the error could just be reproduced on a machines running amd and intel. On Arm the problem does not appear.