search

holoviz / datashader

Quickly and accurately render even the largest data.
http://datashader.org
BSD 3-Clause "New" or "Revised" License
3.26k stars 363 forks source link

Pyarrow version pin causing issues with cuDF #1247

Closed AjayThorve closed 1 year ago

AjayThorve commented 1 year ago

ALL software version info

python 3.10, datashader >= 0.14.4, cuDF>23.06

Description of expected behavior and the observed behavior

1174 pins pyarrow version to <11. Since cuDF v23.06, it requires pyarrow==11.*, causing installation to fail.

Are there any plans to support pyarrow v11?

ianthomas23 commented 1 year ago

I don't think there is any specific reason to keep the pyarrow pin.

AjayThorve commented 1 year ago

oh in that case @ianthomas23, is it okay if I create a PR to remove the pin?

ianthomas23 commented 1 year ago

@AjayThorve I already created the PR, CI passed and I've just merged the PR (#1248).

In general, if there is something that isn't working for you then please do create a PR to fix it.

AjayThorve commented 1 year ago

Thank you so much @ianthomas23 , really appreciate it