search

holoviz / datashader

Quickly and accurately render even the largest data.
http://datashader.org
BSD 3-Clause "New" or "Revised" License
3.24k stars 363 forks source link

Replace accumulate with copy on first call to antialiased stage 2 combine #1264

Closed ianthomas23 closed 11 months ago

ianthomas23 commented 11 months ago

When performing antialiased stage 2 combining of aggs, on the first pass do not need to do the full accumulate as a simple copy will suffice, given that the target aggs are all empty. This gives a slight performance improvement, there is no functional change.

codecov[bot] commented 11 months ago

Codecov Report

Merging #1264 (23d49a5) into main (f263c56) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1264   +/-   ##
=======================================
  Coverage   83.43%   83.44%           
=======================================
  Files          35       35           
  Lines        9069     9071    +2     
=======================================
+ Hits         7567     7569    +2     
  Misses       1502     1502
Files Changed Coverage Δ
datashader/compiler.py 90.03% <100.00%> (ø)
datashader/glyphs/line.py 93.06% <100.00%> (+0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more