holoviz / holonote

Tools to create, edit, and persist annotated regions for HoloViews
https://holonote.holoviz.org
BSD 3-Clause "New" or "Revised" License
21 stars 2 forks source link

Handle empty indicator when groupby is set #118

Closed droumis closed 2 months ago

droumis commented 2 months ago

Fixes #119

Fix error when creating a new annotation from an empty annotator overlaid on an element and when .groupby has been set

codspeed-hq[bot] commented 2 months ago

CodSpeed Performance Report

Merging #118 will not alter performance

Comparing handle_empty (8a44fc0) with main (0e8d4e8)

Summary

✅ 6 untouched benchmarks

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.85%. Comparing base (0e8d4e8) to head (8a44fc0). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #118 +/- ## ========================================== + Coverage 86.77% 86.85% +0.07% ========================================== Files 25 25 Lines 2662 2677 +15 ========================================== + Hits 2310 2325 +15 Misses 352 352 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.