Improve the combination logic for overlaying an annotator

holoviz / holonote

Tools to create, edit, and persist annotated regions for HoloViews

https://holonote.holoviz.org

BSD 3-Clause "New" or "Revised" License

23 stars 2 forks source link

Improve the combination logic for overlaying an annotator #98

Closed hoxbro closed 7 months ago

hoxbro commented 7 months ago

This will now make it easier to add across overlays and layouts.

codspeed-hq[bot] commented 7 months ago

CodSpeed Performance Report

Merging #98 will not alter performance

_{Comparing improve_combination (d772042) with main (95b4074)}

Summary

✅ 6 untouched benchmarks

hoxbro commented 7 months ago

you are welcome to push to this PR. If you do please add test cases too.

droumis commented 7 months ago

Nice, looks good to me.

Nice to know about ~~dmap.callback()~~ hv.plotting.util.initialize_dynamic to activate dmap instead of hv.render and hv.opts._element_keywords("bokeh") to then filter for valid kwargs. Thanks!