Open jbednar opened 6 years ago
Also scipy for some operations.
Ok, added that to the list above.
In chart3d:
class TrisurfacePlot(ColorbarPlot, Chart3DPlot):
style_opts = ['cmap']
def get_data(self, element, ranges):
try:
from scipy.spatial import Delaunay
except:
SkipRendering("SciPy not available, cannot plot Trisurface")
I'm a little confused about the use in operation.timeseries, I don't see scipy imported there but in
TimeseriesOperationTests
I see:
@attr(optional=1) # Requires scipy
def test_roll_date_with_window_type(self):
rolled = rolling(self.date_curve, rolling_window=3, window_type='triang')
rolled_vals = [np.NaN, 2, 3, 4, 5, 6, np.NaN]
self.assertEqual(rolled, Curve((self.dates, rolled_vals)))
Might be an optional dependency downstream though...
Pandas uses SciPy internally for resampling and rolling operations.
Ok, that is what I thought. Either way, scipy does belong on that list...
For anything that holoviews imports but is not declared as a dependency, we should have simple, informative error messages that tell users what to do. E.g.https://github.com/bokeh/datashader/issues/315#issuecomment-323273810 has posts from two different people who could have had a better experience if a message had told them to install datashader. Please edit this text to add any other cases that you know about:
May also need to do something similar for GeoViews.