search

holoviz / holoviews

With Holoviews, your data visualizes itself.
https://holoviews.org
BSD 3-Clause "New" or "Revised" License
2.66k stars 397 forks source link

Very slow hsv_to_rgb in hv.HSV #4221

Open eddienko opened 4 years ago

eddienko commented 4 years ago

The hv.HSV class uses the following to convert the HSV array to RGB:

hsv_to_rgb = np.vectorize(colorsys.hsv_to_rgb)

This is very slow. I would suggest to change this to matplotlib.colors.hsv_to_rgb which operates on arrays.

philippjfr commented 4 years ago

This is very slow. I would suggest to change this to matplotlib.colors.hsv_to_rgb which operates on arrays.

Technically we don't have a hard dependency on matplotlib but we can certainly use it if it's available.