holoviz / holoviews

With Holoviews, your data visualizes itself.
https://holoviews.org
BSD 3-Clause "New" or "Revised" License
2.7k stars 404 forks source link

Downsample on target with RangeToolLink prevents display of data if zoomed and then rangetool-panned #5972

Closed droumis closed 9 months ago

droumis commented 1 year ago

ALL software version info

(this library, plus any other relevant software, e.g. bokeh, python, notebook, OS, browser, etc)

Description of expected behavior and the observed behavior

If you zoom in to the target plot with wheelzoom, and then try to move the rangetool box around in source plot, the data is not refreshed in the target plot.

Complete, minimal, self-contained example code that reproduces the issue

import pandas as pd
import numpy as np
import hvplot.pandas
from holoviews.plotting.links import RangeToolLink

n_samples = 1000
data = np.random.randn(n_samples)

df = pd.DataFrame({'time': np.arange(len(data)), 'value': data})
plot = df.hvplot(x="time", y="value", height=500, downsample=True)
minimap = df.hvplot(x="time", y="value", height=150)
link = RangeToolLink(minimap, plot, axes=["x", "y"])

(plot + minimap).opts(shared_axes=False).cols(1)

Stack traceback and/or browser JavaScript console output

Screenshots or screencasts of the bug in action

https://github.com/holoviz/holoviews/assets/6613202/d6eef3f5-e8ba-42d0-8eba-4a3e1da0c95e

droumis commented 9 months ago

This issue of missing data is resolved by https://github.com/bokeh/bokeh/pull/13603. But it looks like downsampling may not be working.

https://github.com/holoviz/holoviews/assets/6613202/f726346f-5e46-414d-a249-02f284ab00c7

github-actions[bot] commented 2 weeks ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.