search

holoviz / holoviews

With Holoviews, your data visualizes itself.
https://holoviews.org
BSD 3-Clause "New" or "Revised" License
2.66k stars 396 forks source link

Bug fix for player example pause button #6212

Closed mirage007 closed 2 months ago

mirage007 commented 2 months ago

when the pause button is pressed, an exception is thrown that the callback is already removed. This is because it cannot find the the task object. the current code is giving it the wrong object for it to remove.

To fix, the animate task is stored in a dictionary so that it can be used later and removed as necessary.

hoxbro commented 2 months ago

I forgot to thank you for this PR, sorry about that.

Thank you!

mirage007 commented 2 months ago

No problem! Glad to contribute!

On Tue, Apr 30, 2024, 11:34 AM Simon Høxbro Hansen @.***> wrote:

I forgot to thank you for this PR, sorry about that.

Thank you!

— Reply to this email directly, view it on GitHub https://github.com/holoviz/holoviews/pull/6212#issuecomment-2084946947, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAM6CQTCG7CDR54EZVEW6MTY75XSFAVCNFSM6AAAAABG47OXHGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBUHE2DMOJUG4 . You are receiving this because you authored the thread.Message ID: @.***>