search

holoviz / holoviews

With Holoviews, your data visualizes itself.
https://holoviews.org
BSD 3-Clause "New" or "Revised" License
2.69k stars 402 forks source link

Document subcoordinate_group_ranges by extending the EEG Viewer demo #6243

Closed maximlt closed 4 months ago

maximlt commented 4 months ago

This makes the example a bit more complicated as it adds another data dimension but I think overall it is still fine, and from what I understand having multiple groups when dealing with EEG data is not unexpected.

image
droumis commented 4 months ago

Refactored, adding different data type groups, plotting from wide pandas DFs, coloring, rasterization of the minimap, and other minor edits.

image
droumis commented 4 months ago

@maximlt please check my changes

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.47%. Comparing base (2ba3d78) to head (3e8629d). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6243 +/- ## ========================================== + Coverage 88.39% 88.47% +0.08% ========================================== Files 323 323 Lines 67620 67639 +19 ========================================== + Hits 59770 59846 +76 + Misses 7850 7793 -57 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maximlt commented 4 months ago

@droumis very nice updates thanks! I simply added a redirect link in https://github.com/holoviz/holoviews/pull/6243/commits/3e8629d56f4455aa3f89fa77e0507a8b0d0fe6d7 since the EEG Viewer Bokeh demo was already released (I'm running a doc build on the CI now to check if it builds correctly). I'll merge when everything passes.