Closed ahuang11 closed 3 months ago
Attention: Patch coverage is 92.30769%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 88.53%. Comparing base (
dd0e4d5
) to head (f47ffea
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
holoviews/core/dimension.py | 88.88% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes https://github.com/holoviz/holoviews/issues/6244
Not sure why it previously sets to an empty dict, but this makes pickling restore to its original state.
First introduced: https://github.com/holoviz/holoviews/blame/849cd07779be75ff4e4366b3f3f13252afaa43d1/holoviews/core/dimension.py#L764
Prior to that (10 years ago xD): https://github.com/holoviz/holoviews/blame/7c73cefe76c55d10323edcfcd14874cfdbcfc7a9/holoviews/core/dimension.py#L906
I think it might have been an oversight since AttrTree uses
d
https://github.com/holoviz/holoviews/blob/main/holoviews/core/dimension.py#L1353