Closed philippjfr closed 4 weeks ago
Attention: Patch coverage is 80.00000%
with 17 lines
in your changes missing coverage. Please review.
Project coverage is 88.52%. Comparing base (
9cc87fe
) to head (7b0f15f
). Report is 9 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Is this an ok (rough) understanding?
Yes.
How thoroughly have you checked the codebase for this find and replace? The code still seems to use name for range lookup.
Clearly not quite thoroughly enough, will do another more exhaustive check now.
Have you checked if hvplot / GeoViews need updating too?
Yes.
Did miss quite a few. Will scan more thoroughly one more time. Note that this only affects plotting code, so e.g. this isn't affected:
holoviews/holoviews/operation/normalization.py
Line 109 in c8e7f5f
return {d.name: element.range(d.name, self.data_range)
Okay, quite confident now, thoroughly reviewed the plotting code and replaced all remaining cases.
I think the only way we'll catch any more cases will be if we merge and include the change in the RC release.
Implements https://github.com/holoviz/holoviews/issues/6260