holoviz / holoviews

With Holoviews, your data visualizes itself.
https://holoviews.org
BSD 3-Clause "New" or "Revised" License
2.69k stars 402 forks source link

Fix imports for the multichan ts viewer demo #6264

Closed droumis closed 3 months ago

droumis commented 3 months ago

I re-ran the code for good measure and noticed there's a hover tool icon per curve in the toolbar. I don't remember seeing that before. I assume this is due to using the new hover_tooltips option? I guess it's not exactly the expected outcome.

Correct, I had opened an issue here. As documented in that thread, the hover tools do get combined when it becomes a layout rather than an overlay.

droumis commented 3 months ago

using hv.Layout((curves_overlay, hv.Empty())) actually combines the hover tools, but I don't think we should be advertising this workaround

droumis commented 3 months ago

should be ready to merge. I'm guessing that the merging of the "subplot" tools within an overlay will be addressed another time, and otherwise should probably be default behavior for overlays, so there would be nothing to change further in this example.

droumis commented 3 months ago

In future versions, we should update to utilize the wide df mapper approach and NdOverlay instead of hv.Dataset and Overlay. But some issues need to be addressed when combining data from multiple groups with the wide df approach, so let's merge this for now.