search

holoviz / holoviews

With Holoviews, your data visualizes itself.
https://holoviews.org
BSD 3-Clause "New" or "Revised" License
2.66k stars 396 forks source link

Support hit-tested group-wise wheel zoom renderers for subcoordinate_y #6277

Open maximlt opened 3 weeks ago

maximlt commented 3 weeks ago

resolves https://github.com/holoviz/holoviews/issues/6268

By relying on https://github.com/bokeh/bokeh/pull/13826 to be released in Bokeh 3.5, that adds hit-testing properties to the wheel zoom tool. When building a subcoordinate_y overlay with groups which has a default wheel zoom tool, this tool is updated to enable hit-testing, with the hline mode (i.e. zooming is effective only when the mouse intersects horizontally with an element) and the GroupByModels behavior (i.e. zooming only affects a single group at a time).

Monosnap screencast 2024-06-18 17-11-04

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 51.61290% with 15 lines in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (7e5b515) to head (25a51c7). Report is 9 commits behind head on main.

Files Patch % Lines
holoviews/tests/plotting/bokeh/test_subcoordy.py 23.52% 13 Missing :warning:
holoviews/plotting/bokeh/element.py 84.61% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6277 +/- ## ========================================== - Coverage 88.53% 88.53% -0.01% ========================================== Files 323 323 Lines 67934 68020 +86 ========================================== + Hits 60146 60219 +73 - Misses 7788 7801 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

droumis commented 1 week ago

ready for review?

maximlt commented 1 week ago

ready for review?

I'd wait for Bokeh 3.5 to be released.