holoviz / hvplot

A high-level plotting API for pandas, dask, xarray, and networkx built on HoloViews
https://hvplot.holoviz.org
BSD 3-Clause "New" or "Revised" License
1.14k stars 109 forks source link

Added daskgeopandas check to `is_geodataframe` function #1396

Closed Azaya89 closed 2 months ago

Azaya89 commented 2 months ago
ahuang11 commented 2 months ago

Looks good to me! Just a minor addition.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.80%. Comparing base (6c96c7e) to head (ded8eb9). Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
hvplot/tests/testutil.py 84.21% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1396 +/- ## ========================================== + Coverage 87.39% 88.80% +1.40% ========================================== Files 50 51 +1 Lines 7490 7510 +20 ========================================== + Hits 6546 6669 +123 + Misses 944 841 -103 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ahuang11 commented 2 months ago

Thank you looks good now!