search

holoviz / lumen

Illuminate your data.
https://lumen.holoviz.org
BSD 3-Clause "New" or "Revised" License
177 stars 20 forks source link

Catch SQL errors and report on step title #662

Closed ahuang11 closed 3 months ago

ahuang11 commented 3 months ago

Previously, create_sql_expr_source would fail somewhere and would trigger the decorator, but not before the step was able to report error. This makes sure the error bubbles up to the step beforehand so it's easier to debug and that there's no false hope in the resulting SQL expression :P

Before:

image

After:

image
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.40%. Comparing base (6fdcb3a) to head (aae34d7). Report is 1 commits behind head on main.

Files Patch % Lines
lumen/ai/agents.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #662 +/- ## ======================================= Coverage 57.40% 57.40% ======================================= Files 98 98 Lines 11516 11516 ======================================= Hits 6611 6611 Misses 4905 4905 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 5 hours ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.