holoviz / lumen

Illuminate your data.
https://lumen.holoviz.org
BSD 3-Clause "New" or "Revised" License
177 stars 20 forks source link

Limit the amount of data that TableAgent pulls #682

Closed philippjfr closed 2 months ago

philippjfr commented 2 months ago

Accidentally pulling 10s or 100s of millions of rows from a database is not a good experience. So by default we add a SQLLimit, which the user can un-toggle.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 56.70%. Comparing base (e6a8212) to head (7a95810). Report is 1 commits behind head on main.

Files Patch % Lines
lumen/ai/views.py 0.00% 15 Missing :warning:
lumen/ai/agents.py 0.00% 6 Missing :warning:
lumen/transforms/sql.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #682 +/- ## ========================================== - Coverage 56.78% 56.70% -0.09% ========================================== Files 98 98 Lines 11650 11669 +19 ========================================== + Hits 6616 6617 +1 - Misses 5034 5052 +18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.