search

holoviz / lumen

Illuminate your data.
https://lumen.holoviz.org
BSD 3-Clause "New" or "Revised" License
177 stars 20 forks source link

Make SQLLimit more robust #685

Closed philippjfr closed 2 months ago

philippjfr commented 2 months ago

SQLLimit was not wrapping the previous query resulting in errors if the previous query already had a LIMIT or FETCH statement.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.71%. Comparing base (2009652) to head (4fe2eee). Report is 2 commits behind head on main.

Files Patch % Lines
lumen/transforms/sql.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #685 +/- ## ======================================= Coverage 56.70% 56.71% ======================================= Files 98 98 Lines 11669 11673 +4 ======================================= + Hits 6617 6620 +3 - Misses 5052 5053 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.