Closed philippjfr closed 2 months ago
Attention: Patch coverage is 69.04762%
with 13 lines
in your changes missing coverage. Please review.
Project coverage is 56.66%. Comparing base (
f8b02ee
) to head (a1a4f51
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
lumen/transforms/sql.py | 41.66% | 7 Missing :warning: |
lumen/sources/base.py | 73.33% | 4 Missing :warning: |
lumen/sources/duckdb.py | 87.50% | 1 Missing :warning: |
lumen/sources/intake_sql.py | 85.71% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Sometimes SQL data will be incorrectly typed as strings rather than the actual type. Since computing enums for float or integer values is extremely expensive and silly we have the
get_schema
methods speculatively try to cast each column in the subset of columns. If we can successfully cast the subset we will TRY_CAST before computing the min/max values for the schema.