search

holoviz / panel

Panel: The powerful data exploration & web app framework for Python
https://panel.holoviz.org
BSD 3-Clause "New" or "Revised" License
4.62k stars 504 forks source link

SVG logos don't work on all platforms? #2618

Open jbednar opened 3 years ago

jbednar commented 3 years ago

As mentioned in https://github.com/holoviz/panel/pull/2609, on some platforms it seems that at least some Panel logo SVGs show up in Times Roman rather than the Ubuntu font they were designed for. @MarcSkovMadsen, it sounds like you have access to such a platform, so can you please view the following SVGs and check the box if it appears properly on that platform?

@philippjfr , do we need this seemingly out-of-date version? https://github.com/holoviz/panel/blob/master/doc/_static/logo_stacked_square.svg

jbednar commented 3 years ago

Also, I think we should extend the standard logo filenames officially to cover the various cases above. The existing list of standard names doesn't have anything about theming yet. Presumably "currentColor" should be "current_color" to match the other names, as well.

mattpap commented 3 years ago

Ubuntu is not a universal font, so the behavior here is correct (falling back to the default font). If you want to keep the specific font and make things platform independent, then given this is a one word logo, I would convert the text node into a path and sever reliance on text rendering altogether.

jbednar commented 3 years ago

Right; just need to find out which (or is it all?) logo files have not been converted in that way.

mattpap commented 3 years ago

It's all (relevant). Converting text to paths increases SVG size by about 30% (still insignificant compared to PNG).