search

holoviz / panel

Panel: The powerful data exploration & web app framework for Python
https://panel.holoviz.org
BSD 3-Clause "New" or "Revised" License
4.69k stars 508 forks source link

Front page app invisible text in dark mode #6894

Open ahuang11 opened 4 months ago

ahuang11 commented 4 months ago

The widgets labels are invsible.

image
philippjfr commented 3 months ago

Thanks, until we have CSS styling of the plot we should disable dark mode again.

Coderambling commented 3 months ago

Disable it only on that and similar pages I assume? Not actually disable it for the whole site?

philippjfr commented 3 months ago

Disable it only on that and similar pages I assume? Not actually disable it for the whole site?

Yes for the whole site, a) there's no way to do it for specific pages and b) we will never catch all the pages where there might be an issue.

Coderambling commented 3 months ago

Oof that seems quite a downgrade in terms of site functionality.

And it also doesn't look good in terms of perception.

I assume the invisible text issue occurs multiple times?

Users can probably fall back to a browser-level Dark Mode toggle, but still.

Is there a development path / PR to enable CSS for plots, so that there is a way back to re-enable dark mode at some point?

Should that happen at the Panel level, Bokeh level or somewhere else?

philippjfr commented 3 months ago

Oof that seems quite a downgrade in terms of site functionality.

We had dark mode disabled for the longest time for this reason but recent versions of the pydata-sphinx-theme changed the APIs we used to disable it.

to enable CSS for plots, so that there is a way back to re-enable dark mode at some point?

Yes, it's being worked on in Bokeh 3.5 and 3.6.