search

holoviz / param

Param: Make your Python code clearer and more reliable by declaring Parameters
https://param.holoviz.org
BSD 3-Clause "New" or "Revised" License
412 stars 69 forks source link

Refactor `__init__.py`, mostly by moving Parameters to `parameters.py` #852

Closed maximlt closed 9 months ago

maximlt commented 9 months ago

Fixes https://github.com/holoviz/param/issues/648

This is also adding __all__ to the __init__.py.

When you start to touch so many lines it's tempting to do some formatting and even more refactoring, styling, imports sorting, etc.. I've decided to stick to address the limitations exposed in the issue; this can be done later.

I think Github supports ignoring specific commits on blame, I'll enable that once this is merged.

jbednar commented 9 months ago

Thanks. The large-scale moves here make sense, but are hard to review, so I'll just trust you didn't insert anything beyond what was already there. :-)

Are there special techniques to preserve git blame in a case like this? E.g. if the git history includes git mv __init__.py parameters.py followed by recreating __init__.py, will github know that the history of the classes in parameters.py can be found in older __init__.py versions? Now would be the time to be careful about that, and I don't know how best to achieve that.