search

holoviz / param

Param: Make your Python code clearer and more reliable by declaring Parameters
https://param.holoviz.org
BSD 3-Clause "New" or "Revised" License
412 stars 69 forks source link

Do not install “doc” in site-packages (fix #877) #878

Closed musicinmybrain closed 8 months ago

musicinmybrain commented 8 months ago

Tested in a clean git checkout:

python3 -m build
python3 -m wheel unpack dist/param-*.whl
find param-*/doc/
find: ‘param-*/doc/’: No such file or directory
maximlt commented 8 months ago

Hi @musicinmybrain, thanks for spotting that, it's indeed pretty bad :/ I was surprised to see that though as in pyproject.toml the target folders were explicitly specified. Except that not quite like hatch expected it! Prefixing them with a slash fixed it, which is the real fix.

musicinmybrain commented 8 months ago

Hi @musicinmybrain, thanks for spotting that, it's indeed pretty bad :/

As a Linux distribution packager, I’ve seen it dozens of times, including in official projects from billion-dollar companies. Don’t feel bad! It’s easy to miss stray files in a virtualenv.

Prefixing them with a slash fixed it, which is the real fix.

I agree that this is a much better fix. Thank you!