search

holoviz / spatialpandas

Pandas extension arrays for spatial/geometric operations
BSD 2-Clause "Simplified" License
308 stars 25 forks source link

Strip protocol for comparison #33

Closed brl0 closed 4 years ago

brl0 commented 4 years ago

Fixes #32

jonmmease commented 4 years ago

This approach does look better. Only concern is that filesystem._strip_protocol looks like a private method in fsspec. Is there anything in the public API to do this?

jbednar commented 4 years ago

@martindurant, any comments on that question?

martindurant commented 4 years ago

I'm not sure what the specific change here is, but I have no problem with a library calling _strip_protocol - it is internal in the sense that I don't expect end-users to ever call it. Note that some protocols, perhaps only http/s, don't actually strip anything at all.

jbednar commented 4 years ago

Ok, sounds safe enough then. Thanks, all!