More intuitive error when lsuffix == rsuffix on sjoin

holoviz / spatialpandas

Pandas extension arrays for spatial/geometric operations

BSD 2-Clause "Simplified" License

308 stars 25 forks source link

More intuitive error when lsuffix == rsuffix on sjoin #35

Closed Adam-D-Lewis closed 4 years ago

Adam-D-Lewis commented 4 years ago

Right now, callling joined = spd.sjoin(sddf, sdf, how='inner', lsuffix='leftsuffix', rsuffix='rightsuffix') results in RecursionError: maximum recursion depth exceeded while calling a Python object.

It'd be nice to have a Exception message saying something like "lsuffix and rsuffix must not be equal"

jbednar commented 4 years ago

Sure! PR gratefully accepted, if you're able!

Adam-D-Lewis commented 4 years ago

I can't commit to making the PR right now, but I wanted to at least get this documented for others. This would probably make a good first issue if someone is looking to contribute.

brl0 commented 4 years ago

This was addressed in #37 and can probably be closed now.

Adam-D-Lewis commented 4 years ago

Awesome, thanks!