search

holoviz / spatialpandas

Pandas extension arrays for spatial/geometric operations
BSD 2-Clause "Simplified" License
308 stars 25 forks source link

Minor fixes #37

Closed brl0 closed 4 years ago

brl0 commented 4 years ago

Closes #34, #35, #36

If possible, and if this is accepted, it would be helpful to cut a new release once merged.

jbednar commented 4 years ago

I'm happy to merge once the tests pass, but on first glance I can't see what those test failures are about. Probably unrelated to this PR, but still seem like they need addressing.

tylerpotts commented 4 years ago

@jbednar Would it be possible to merge this anyways and cut a release despite the tests failing? We rely on one of the bug fixes in this PR and currently are pip installing from the git hash

brl0 commented 4 years ago

Fixes #41 and #42, along with a couple of other minor issues. All tests should be passing now.

jbednar commented 4 years ago

Thanks so much! I'll tag a dev release.

jbednar commented 4 years ago

Tagged: https://github.com/holoviz/spatialpandas/releases/tag/v0.3.5a0

For our other projects, tagging is all that's required for making a release, with the release process automated on Travis. It looks like none of that has been set up on this library yet, so I don't actually know what the process is for making pip and conda packages appear for spatialpandas. @jlstevens, any suggestions?