holtwick / briefing

🔮 Secure direct video group chat
https://brie.fi/ng
GNU Affero General Public License v3.0
1.44k stars 240 forks source link

fix switchMedia: stop previous track before switch #131

Closed manhere closed 2 years ago

manhere commented 2 years ago

manually emit the event, some webview implement (firefox, android...) doesn't fire track-ended event, most common error thrown as "Could not start video source"

manhere commented 2 years ago

related explanation Why is the 'ended' event not firing for this MediaStreamTrack?

holtwick commented 2 years ago

Thanks @manhere I will look at it later today. Indeed, the last remaining issues are about video input. FYI extract from Sentry logging of the current active version:

20221014-090512-capture-holtwick@2x

holtwick commented 2 years ago

Thanks to your fix, we are now crash free 👍

20221021-130833-capture-holtwick@2x