search

holtzermann17 / key-mon

Automatically exported from code.google.com/p/key-mon
Apache License 2.0
0 stars 0 forks source link

--novisible_click has no effect #116

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Steps to reproduce:
1. Edit config file to show visible clicks (or set it via the program settings 
menu).
2. Launch key-mon with --novisible_click.
3. Clicks are visibile by default.

This bug has been originally reported in Debian[1]. Since I am the maintainer 
of the package, I am wondering if this is either a deliberate behavior or a bug.

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=650043

IMO, command line options should override configuration file settings. Rather 
than patch the package in Debian, I would like to know if you agree with my 
point of view, or if you have reasons to support the current behavior.

Original issue reported on code.google.com by andrea.c...@gmail.com on 25 Jun 2012 at 6:02

GoogleCodeExporter commented 9 years ago 
Yes, command line should override other preferences.  The preferences setup and 
grown organically and has a few warts because of it.

Original comment by scottaki...@gmail.com on 25 Jun 2012 at 6:32

GoogleCodeExporter commented 9 years ago 
Yeah, I see. Do you think a new release, or at least a patch, might be 
available before June 30th? That is the day Debian will be frozen, it would be 
great to have a fix before it.

Original comment by andrea.c...@gmail.com on 25 Jun 2012 at 8:13

GoogleCodeExporter commented 9 years ago 
The attached patch seems to fix the issue, however, the option and ini parser 
are little bit confusing for me. So, this might have side-effect which I didn't 
see. IIRC, there was an issue about the overriding and a revert was made for 
the options.py.

Needs reviewing and testing.

Original comment by livibet...@gmail.com on 26 Jun 2012 at 1:11

Attachments:

GoogleCodeExporter commented 9 years ago 
Fixed in 1.12 by verifying that the parameter is actually passed on the command 
line instead of examining if it's different from default.

Original comment by scottaki...@gmail.com on 26 Jun 2012 at 11:45

GoogleCodeExporter commented 9 years ago 
I tried the 1.12 tarball, and looks like the issue is still there, unchanged. 
Anybody can confirm that?

Original comment by andrea.c...@gmail.com on 27 Jun 2012 at 8:45

GoogleCodeExporter commented 9 years ago 
Thanks for testing.
I believe I've got all the issues now.

Original comment by scottaki...@gmail.com on 27 Jun 2012 at 2:08

GoogleCodeExporter commented 9 years ago 
It works great now, thank you!
I will upload the updated package to Debian (and then sync to Ubuntu) today.

Original comment by andrea.c...@gmail.com on 29 Jun 2012 at 8:12

GoogleCodeExporter commented 9 years ago 
Since it's fixed, closing.

Original comment by livibet...@gmail.com on 2 Jul 2012 at 5:40