search

holtzy / D3-graph-gallery

A collection of simple graphics made with D3.js
https://www.d3-graph-gallery.com
MIT License
791 stars 237 forks source link

Code cleanup #3

Closed Nedlinin closed 5 years ago

Nedlinin commented 5 years ago

Mostly just cleaning up mismatched tags and condensing a few CSS properties. Also fix some logical OR operators that were given as bitwise ops instead.

holtzy commented 5 years ago

Thanks @Nedlinin! How did you proceed to find out so many mistakes? cheers,

Nedlinin commented 5 years ago

Noticed the page didn't load properly for me on Chrome/Firefox. When I saw a Github link I took a look. #2 was to fix the loading issues and while I was in there I took a look at the code using an inspection tool built into my IDE. Saw a bunch of low hanging fruit (#3) so I took the few minutes to lend a hand.

holtzy commented 5 years ago

Thank you very much for your help, this is much appreciated