search

holtzy / D3-graph-gallery

A collection of simple graphics made with D3.js
https://www.d3-graph-gallery.com
MIT License
791 stars 237 forks source link

Typo in Highlight links in arc diagram #8

Open padraighu opened 4 years ago

padraighu commented 4 years ago

In the code section in page https://www.d3-graph-gallery.com/graph/arc_highlight.html, I think there is a typo: // Add the highlighting functionality nodes .on('mouseover', function (d) { // Highlight the nodes: every node is green except of him nodes.style('fill', "#B8B8B8") d3.select(this).style('fill', '#69b3b2') It should be every node is grey except of him since the highlighted node is in green while the other nodes are in grey.

holtzy commented 3 years ago

Hmm, I still see this error even though the PR has been merged 🤔

padraighu commented 3 years ago

Interesting... My merge request changed the comment in arc.html. It appears that there are 2 other HTML files with the same comment: arc_highlight.html, and arc_template.html.

I'm not sure how these files relate to each other but perhaps the comments should be changed in those 2 as well?