search

holub008 / xrf

eXtreme RuleFit (sparse linear models on XGBoost ensembles)
Other
43 stars 13 forks source link

Current xgboost objective is now deprecated #19

Closed juliasilge closed 2 years ago

juliasilge commented 2 years ago

The objective function for xgboost like this:

https://github.com/holub008/xrf/blob/ea02526427e72a2d97bd6fdb3922dd7343c52dbc/R/xrf.R#L89

has been deprecated. When we use xrf we get warnings such as:

WARNING: amalgamation/../src/objective/regression_obj.cu:188: reg:linear is now deprecated in favor of reg:squarederror
holub008 commented 2 years ago

Shoot! Thanks @juliasilge, I'll patch this up.

holub008 commented 2 years ago

Update: I'm trying to clear other warnings up to go with this release. Namely #16, which seems to possibly require an upstream fix. Depending on if there's something I can do to resolve or not, I will progress release.

holub008 commented 2 years ago

@juliasilge 0.2.1 is released, and this should be patched, in addition to some other warnings/noise from XGB. I did a reverse depends check on rules, but let me know if anything looks off on your end. Thanks for filing!

juliasilge commented 2 years ago

Thank you so much @holub008! 🙌