search

holunda-io / camunda-bpm-taskpool

Library for pooling user tasks and process related business objects.
https://www.holunda.io/camunda-bpm-taskpool/
Apache License 2.0
68 stars 26 forks source link

fix: prevent standalone UpdateAttributesHistoricTaskCommand from bein… #770

Closed lbilger closed 1 year ago

lbilger commented 1 year ago

…g published

Fixes #769

zambrovski commented 1 year ago

I don't really understand how the build of your PR was successful, but the merge caused the pipeline to become read and it remains read.

The TaskCollectorITest is failing in change candidate group / user per API tests because now the update event gets fired... To me it is not an error in the test, but the implementation breaks the existing contract.

I'll need to understand this because:

1) if we can't prevent this break I can't accept this PR and would revert it. 2) if there is a way to get previous and new test green I'll merge and release

Sorry and cheers,

Simon

lbilger commented 1 year ago

Strange - locally I probably forgot to run the build with the itest profile but github should have caught it. Does the build even run on pull request checks?

Anyway, I created a new PR that fixes the test. Please have a look if there are any implications I did not see, but for me, all tests are green now even with the itest profile active.