Closed holyturt closed 6 years ago
Hey @holyturt,
Great to see your changes! I was on vacation the last couple of weeks, and just saw the pull request. I'll be going through the files and add comments as I go along, just like I would during a code review. If you have any questions, suggestions or remarks, or if you have any ideas for the process, please comment.
Hey, @wtimme! Thank you for your review! That’s very helpful. I will merge this PR with confidence!
This branch attempts to change
OverpassQuery
and its related classes to avoid user to make wrong query relationships. Especially, it:OverpassQuery
,// after let node = NodeQuery() let way = node.way()
OverpassQuery
to new classXMLQueryBuilder
to clarify these classes' concern and make it simpler.This will have breaking changes and incompatibilities. Any ideas?