search

holzschu / a-shell

A terminal for iOS, with multiple windows
BSD 3-Clause "New" or "Revised" License
2.61k stars 117 forks source link

YouTube is broken in internalbrowser #743

Open BareGamer opened 8 months ago

BareGamer commented 8 months ago

I made a simple shortcut to replace an existing, but not working on iOS for some reason, youtube PWA. However, when you get to the front page, it opens the video previews that are autoplayed in fullscreen. It’s especially a problem because it starts opening and autoplaying shorts. Pretty sure this isn’t supposed to happen, at least it doesn’t in the other internal browsers. (worth noting that none of the videos were played/paused/switched by me, only exited) RPReplay_Final1705273041.webm

holzschu commented 8 months ago

I tried opening both http://www.youtube.com and https://www.youtube.com/watch?v=PgiPaanDnuk with the internalbrowser and I could not get the behaviour you describe. I'm going to need more information in order to reproduce and possibly fix this issue. What I can tell you is that the internalbrowser, for good or for bad, does not do anything with the web page: it just displays it.

BareGamer commented 8 months ago

I tried opening both http://www.youtube.com and https://www.youtube.com/watch?v=PgiPaanDnuk with the internalbrowser and I could not get the behaviour you describe. I'm going to need more information in order to reproduce and possibly fix this issue. What I can tell you is that the internalbrowser, for good or for bad, does not do anything with the web page: it just displays it.

Looks like it happens only on the main page for me, previews don’t really play in video recommendations. I’d be happy to provide more information, but not sure what else might be useful.

holzschu commented 8 months ago

The main question is: "what can I do to reproduce the issue, which is necessary for me order to (attempt to) fix it?".

What do you mean by "the main page"? Is that "www.youtube.com"? If so, the issue does not happen on my side, so there might be something else that is different between our machines, maybe user settings. Is it some other address? If so, which one? How are you calling the internalbrowser? (you said it was from a Shortcut). Do you see the same behaviour when opening the URL from the app instead of the Shortcut? Can you share the Shortcut, and maybe I can have a look at what happens? In short: "how can I reproduce the issue?"

BareGamer commented 8 months ago

Okay, I’ll try to be as detailed as possible: yes, I am talking about https://youtube.com specifically. Both ways I call internalbrowser - being with an “execute” shortcut and from the console - make it behave the way I showed. It happens only in a-shell, not in any other internal browser or Safari. I am running iOS 17.2.1 on an iPhone 11, but I think this issue has happened from at least 17. Also happens both in a-Shell and mini(which I am using for the shortcut). Here is a link to the shortcut if it will be useful: https://www.icloud.com/shortcuts/a5a02588ee26409782b71447e746205e

BareGamer commented 8 months ago

Here’s how it looks in Safari, both logged in and out.

https://github.com/holzschu/a-shell/assets/78811370/66547d20-4b1d-4e15-96de-14d46df399b4

Are you logged in in the internal browser(I am not)? Maybe that affects this behavior somehow?

BareGamer commented 2 months ago

As of today, the bug is still happening. Essentially I’m writing this because not too long ago I realised that it looks like my webview has been broken for 2 years and counting (thanks Apple) because the “share” button in it doesn’t work. I think it was working when I only got the phone on iOS 15, but later it broke, and it’s been broken for so long that I’ve forgotten it’s not supposed to do that. What I’m trying to say is if such a thing can happen, then this bug can happen too(again-only happens in ash. The webview from Shortcuts works for example). I think the only way to find out if it’s the webview would be to factory reset the phone, but I’m not going to do that unless I really need to.

natty291 commented 2 months ago

I don't know why the behavior is different between safari and internalbrowser, but it seems to be possible to work around it by changing youtube settings.

setting/account/Video previews(off)

In my environment(iPhone), the phenomenon does not seem to occur in landscape mode.