search

holzschu / a-shell

A terminal for iOS, with multiple windows
BSD 3-Clause "New" or "Revised" License
2.57k stars 115 forks source link

Internalbrowser (webview) doesn't display text picker UI #798

Open 2gn opened 1 month ago

2gn commented 1 month ago

Steps to reproduce

  1. internalbrowser https://google.com
  2. Try to select texts by long pressing on texts
  3. Text will be selected, but the text picker UI (blue transparent overlay) doesn't appear

Expected behavior

Normally, text selection should look like this

image

This is extremely useful when editing code on webview based code editors like ace, monaco and codemirror.

holzschu commented 1 month ago

I followed the steps, and got this result, which seems to be the expected behavior: IMG_0487 We’re going to need more tests about when this happens, in order to fix it.

2gn commented 1 month ago

I'm on a-Shell v1.15.0 on iPhone OS. I'll check if it happens on my iPad.

I just tried it on Testflight version and when I open https://google.com, it did showed the text picker. However, webview based code editor still doesn't show anything like that.

holzschu commented 1 month ago

On my phone, I have the blue transparent overlay, but not the handles with Google and ace-editor, I have the blue transparent overlay and the handles with codemirror. To the best of my knowledge, there are no differences between the iPhone and iPad code, so it must be something weirdly specific.