search

holzschu / ios_system

Drop-in replacement for system() in iOS programs
BSD 3-Clause "New" or "Revised" License
891 stars 146 forks source link

Valid zips #113

Closed yury closed 3 years ago

yury commented 3 years ago

Hello,

Sorry for bombarding you with PRs. But I found issue with zipping XCFrameworks with Catalyst. Turns out zip by default expands symlink. MacOSX and Catalyst frameworks use symlinks inside, so the have doubled everything inside and the worst part - Xcode can't sign them.

So I added --symlinks flag to zip. I tested everything and now they are really good Catalyst frameworks.

Will make PR for network_ios too

holzschu commented 3 years ago

Hi, No problems with the PR. They solved a major issue with the building system. There is a strong chance that Apple will introduce something similar at WWDC 2021.

I can't test on Catalyst, so I'll trust you with this PR.

yury commented 3 years ago

Thank you, can you also retag? I wanna make PR for network_ios today

holzschu commented 3 years ago

The new version is now retagged.