Open discussion : how to manage bootstrap upgrades

[alafon]

Bootstrap development follow-up

Solution 1

• configure bootstrap as a git submodule (in lib/bootstrap for instance), set on a specific commit. Might be simple in terms of upgrades but it might introduce some bugs in case of buggy releases... Depends if we want to always be on the bleeding edge or not
• write a script to create some symlinks to maintain the relation between the eZ Publish extension structure and the bootstrap clone => might be a problem for Windows users but do we care about them ? :p

  Solution 2

• write a script that checkouts a specific branch/tag of bootstrap and then copy it in the good folders

  Solution 3

• do it manually (which is not a bad solution since it takes less than 1 hour ...)

  Common needs

• a script that
  • updates variables.less and other bootstrap-related files
  • adds hwboot specific files

    Questions

• should it be shell based ? php based ?
• if php based, should we think of something in the admin interface to make it updatable by anybody ?
• ....

[alafon]

Should be in milestone 1.1 by the way ;)

[workflow]

Since we are likely to need a check after each upgrade, I would vote against Solution 1.

How about:

Solution 4

• We alter the directory structure, so that all bootstrap's .less files reside within an extra bootstrap/ directory and
• override files like variables.less one hierarchy level higher.
• (same process for .js)

This way we would preserve the upgrade path, and upgrading bootstrap becomes, as simple as overwriting the two boostrap/ directories, throwing in the new .less and .js files, and possibly including any files that are new. For clarification:

• design/hwboot/stylesheets/bootstrap/* --> Bootstrap .less files
• design/hwboot/javascript/bootstrap/* --> Bootstrap .js files
• design/hwboot/stylesheets/bootstrap/variables.less --> Bootstrap's variables.less
• design/hwboot/stylesheets/variables.less --> our own custrom version, overriding things. (Or a similar structure, if we want to keep the .css files as well)

This is probably fast and easy enough to cancel out any need for automation.

What be your thoughts?

[tobiasstrebitzer]

i agree @workflow, we should place the source files in a "bootstrap" directory underneath "stylesheets" or "stylesheets/less", or maybe "stylesheets/lib". Any changes to the bootstrap source (which should always be the last alternative) shoud then be done in override less files (like stylesheets/carousel.less overrides stylesheets/bootstrap/carousel.less).

Changes relating to ezpublish (i.e. ezdemo) should be done in "stylesheets/hwboot.less". hwboot.less is currently the only file where styles are placed. As it currently is not too large, we'll stick to that, but maybe we'll have to split it up lateron.

Additionally, we should add bootstrap as a submodule, like @alafon suggested in Solution 1.

The recent upgrade to bootstrap 2.0.0 worked charmingly well btw.