homalg-project / CAP_project

CAP project -- Categories, Algorithms, and Programming
https://homalg-project.github.io/docs/CAP_project-based/
24 stars 18 forks source link

Switch the arguments of (Co)ClosedMonoidalLeft/RightCoevaluationMorphism #1577

Closed mohamed-barakat closed 9 months ago

mohamed-barakat commented 9 months ago

For the legacy CAP operations of the parametric adjunction $-\otimes a \dashv \mathrm{\underline{Hom}}(a,-)$

(note: in the documentation of CoevaluationMorphism $a$ and $b$ are permuted)

Contra-intuitively, the first argument $b$ of CoevaluationMorphism is the component while the second is the parameter $a$ of the parametric adjunction. In any case, the orders of the arguments for the unit and the counit are incompatible.

Now that we have the new names ClosedMonoidalLeftEvaluationMorphism etc., I would like to fix this mismatch. If desired I could also change CoevaluationMorphism from currently being a (backward compatibility) synonym of ClosedMonoidalLeftEvaluationMorphism to an operation exhibiting the old flipped order of arguments.

mohamed-barakat commented 9 months ago

If there are no objections the next PR will address this issue.