search

homalg-project / CAP_project

CAP project -- Categories, Algorithms, and Programming
https://homalg-project.github.io/docs/CAP_project-based/
24 stars 18 forks source link

standardized order of arguments of unit/counit for (co)closed monoidal categories #1578

Closed mohamed-barakat closed 9 months ago

mohamed-barakat commented 9 months ago

the first argument is the parameter (of the parametric adjunction) and the second is the component

these changes affect three of the four operations:

resolves https://github.com/homalg-project/CAP_project/issues/1577

codecov[bot] commented 9 months ago

Codecov Report

Attention: 88 lines in your changes are missing coverage. Please review.

Comparison is base (7bb28f5) 81.61% compared to head (bd66cde) 81.74%.

Files Patch % Lines
...mmetricCoclosedMonoidalCategoriesDerivedMethods.gi 45.00% 22 Missing :warning:
...recompiled_categories/MatrixCategoryPrecompiled.gi 50.00% 9 Missing :warning:
...gap/CocartesianCoclosedCategoriesDerivedMethods.gi 53.33% 7 Missing :warning:
...esentationsForCAP/gap/ModulePresentationsForCAP.gi 46.15% 7 Missing :warning:
...ap/LeftCoclosedMonoidalCategoriesDerivedMethods.gi 53.33% 7 Missing :warning:
...tricCocartesianCoclosedCategoriesDerivedMethods.gi 40.00% 6 Missing :warning:
CartesianCategories/gap/Synonyms.gi 66.66% 6 Missing :warning:
MonoidalCategories/gap/Synonyms.gi 66.66% 6 Missing :warning:
...es/gap/CoclosedMonoidalCategoriesDerivedMethods.gi 66.66% 5 Missing :warning:
...mmetricCoclosedMonoidalCategoriesDerivedMethods.gi 60.00% 4 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1578 +/- ## ========================================== + Coverage 81.61% 81.74% +0.13% ========================================== Files 513 515 +2 Lines 67553 67564 +11 ========================================== + Hits 55134 55233 +99 + Misses 12419 12331 -88 ``` | [Flag](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | Coverage Δ | | |---|---|---| | [ActionsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `64.09% <ø> (ø)` | | | [AttributeCategoryForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `88.88% <ø> (ø)` | | | [CAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `84.67% <ø> (ø)` | | | [CartesianCategories](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `93.27% <72.83%> (-0.09%)` | :arrow_down: | | [CompilerForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `96.10% <ø> (ø)` | | | [ComplexesAndFilteredObjectsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `73.60% <ø> (ø)` | | | [FreydCategoriesForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `81.15% <100.00%> (-0.04%)` | :arrow_down: | | [GeneralizedMorphismsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `61.60% <ø> (ø)` | | | [GradedModulePresentationsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `44.62% <ø> (ø)` | | | [GroupRepresentationsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `72.05% <ø> (ø)` | | | [HomologicalAlgebraForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `73.21% <ø> (ø)` | | | [InternalExteriorAlgebraForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `93.09% <ø> (ø)` | | | [LinearAlgebraForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `66.86% <57.14%> (ø)` | | | [ModulePresentationsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `68.66% <53.33%> (ø)` | | | [ModulesOverLocalRingsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `90.70% <ø> (ø)` | | | [MonoidalCategories](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `89.34% <72.67%> (+1.09%)` | :arrow_up: | | [ToricSheaves](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1578/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `21.79% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.