homalg-project / CAP_project

CAP project -- Categories, Algorithms, and Programming
https://homalg-project.github.io/docs/CAP_project-based/
24 stars 18 forks source link

Fix a logic function potentially producing wrong results #1632

Closed zickgraf closed 2 months ago

zickgraf commented 2 months ago

in contexts with partial type information

I hope that this has not caused issues in production code due to contexts usually either having full or no type information.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.93%. Comparing base (c4812f1) to head (73d9091).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1632 +/- ## ======================================= Coverage 81.93% 81.93% ======================================= Files 532 532 Lines 70574 70577 +3 ======================================= + Hits 57826 57829 +3 Misses 12748 12748 ``` | [Flag](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | Coverage Δ | | |---|---|---| | [ActionsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `64.09% <ø> (ø)` | | | [AttributeCategoryForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `88.88% <ø> (ø)` | | | [CAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `84.81% <ø> (ø)` | | | [CartesianCategories](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `91.77% <ø> (ø)` | | | [CompilerForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `96.00% <100.00%> (+<0.01%)` | :arrow_up: | | [ComplexesAndFilteredObjectsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `73.60% <ø> (ø)` | | | [FreydCategoriesForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `81.28% <ø> (ø)` | | | [GeneralizedMorphismsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `61.60% <ø> (ø)` | | | [GradedModulePresentationsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `44.62% <ø> (ø)` | | | [GroupRepresentationsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `72.05% <ø> (ø)` | | | [HomologicalAlgebraForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `73.21% <ø> (ø)` | | | [InternalExteriorAlgebraForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `93.09% <ø> (ø)` | | | [LinearAlgebraForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `67.25% <ø> (ø)` | | | [ModulePresentationsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `68.79% <ø> (ø)` | | | [ModulesOverLocalRingsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `90.70% <ø> (ø)` | | | [MonoidalCategories](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `89.48% <ø> (ø)` | | | [ToricSheaves](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1632/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `21.79% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.