search

homalg-project / CAP_project

CAP project -- Categories, Algorithms, and Programming
https://homalg-project.github.io/docs/CAP_project-based/
24 stars 18 forks source link

Re-encode data types of empty lists #1634

Closed zickgraf closed 2 months ago

zickgraf commented 2 months ago

@mohamed-barakat If I compile FinQuivers in FunctorCategories with this PR, I get the following code:

    ##
    AddInitialObject( cat,

########
function ( cat_1 )
    local deduped_1_1;
    deduped_1_1 := BigInt( 0 );
    return CreateCapCategoryObjectWithAttributes( cat_1, DefiningTripleOfQuiverEnrichedOverSkeletalFinSets, NTuple( 3, deduped_1_1, deduped_1_1, CapJitTypedExpression( [  ], function (  )
                return rec(
                    filter := IsList,
                    element_type := rec(
                        filter := IsInt ) );
            end ) ) );
end
########

    , 100 );

Notice that the third entry of DefiningTripleOfQuiverEnrichedOverSkeletalFinSets is annotated to be a list of integers. However, according to the type declaration, the third entry of DefiningTripleOfQuiverEnrichedOverSkeletalFinSets should be a list of pairs of integers. I have checked the data types in FinSetsForCAP and have actually found a problem (https://github.com/homalg-project/FinSetsForCAP/pull/257), but this does not fix the above. Hence, I assume that some type declaration in FunctorCategories is wrong. Would you like to have a look before I merge, or shall I merge and we fix things afterwards?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.95%. Comparing base (6cfa137) to head (848012f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1634 +/- ## ========================================== + Coverage 81.93% 81.95% +0.01% ========================================== Files 532 532 Lines 70577 70642 +65 ========================================== + Hits 57829 57894 +65 Misses 12748 12748 ``` | [Flag](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | Coverage Δ | | |---|---|---| | [ActionsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `64.09% <ø> (ø)` | | | [AttributeCategoryForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `88.88% <ø> (ø)` | | | [CAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `84.81% <ø> (ø)` | | | [CartesianCategories](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `91.77% <ø> (ø)` | | | [CompilerForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `96.04% <100.00%> (+0.03%)` | :arrow_up: | | [ComplexesAndFilteredObjectsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `73.60% <ø> (ø)` | | | [FreydCategoriesForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `81.28% <ø> (ø)` | | | [GeneralizedMorphismsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `61.60% <ø> (ø)` | | | [GradedModulePresentationsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `44.62% <ø> (ø)` | | | [GroupRepresentationsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `72.05% <ø> (ø)` | | | [HomologicalAlgebraForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `73.21% <ø> (ø)` | | | [InternalExteriorAlgebraForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `93.09% <ø> (ø)` | | | [LinearAlgebraForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `67.25% <ø> (ø)` | | | [ModulePresentationsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `68.79% <ø> (ø)` | | | [ModulesOverLocalRingsForCAP](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `90.70% <ø> (ø)` | | | [MonoidalCategories](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `89.48% <ø> (ø)` | | | [ToricSheaves](https://app.codecov.io/gh/homalg-project/CAP_project/pull/1634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `21.79% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.