homalg-project / CAP_project

CAP project -- Categories, Algorithms, and Programming
https://homalg-project.github.io/docs/CAP_project-based/
24 stars 18 forks source link

Drop support for installing CAP operations with additional filters #1651

Closed zickgraf closed 5 days ago

zickgraf commented 2 weeks ago

CAP has support for installing methods for CAP operations with additional filters, for example for speeding up the composition with identity morphisms in CategoryOfRows: https://github.com/homalg-project/CAP_project/blob/c3a0d09a41b25da86d14bd2e19723563eadb41f8/FreydCategoriesForCAP/gap/CategoryOfRows.gi#L419-L423

I propose dropping support for this mechanism. Reasoning:

@sebastianpos Do you see the need to keep the mechanism?

@mohamed-barakat @kamalsaleh Do you have any code relying on this?

mohamed-barakat commented 2 weeks ago

We now have the compiler. From my side, this mechanism can be dropped.

zickgraf commented 2 weeks ago

We now have the compiler. From my side, this mechanism can be dropped.

I agree, but just for the record: compilation is not an exact replacement for this mechanism, because the mechanism can dynamically optimize at runtime while compilation can only statically optimize at compile time.

mohamed-barakat commented 2 weeks ago

I agree. The compiler does not support this branching, so it is useless for the compiled code, but relevant during runtime if one uses the noncompiled code.