search

homalg-project / CAP_project

CAP project -- Categories, Algorithms, and Programming
https://homalg-project.github.io/docs/CAP_project-based/
24 stars 18 forks source link

Some nomenclature in MonoidalCategories is broken #1665

Closed zickgraf closed 1 month ago

zickgraf commented 2 months ago

There are some files named

MonoidalCategoriesTensorProductAndUnit...

and some files named

MonoidalCategoriesTensorProductOnObjectsAndUnitObject...

which actually belong together. This is confusing and I think both names are bad. I suggest the prefix

MonoidalCategoriesTensorProductOnObjectsAndTensorUnit...

instead.

Cause: The file MonoidalCategoriesTensorProductAndUnitMethodRecord.gi was not properly renamed in https://github.com/homalg-project/CAP_project/commit/9cfb4d91bc12cba055db1713b8285be2f72025f7.

mohamed-barakat commented 2 months ago

I agree. I can do the renaming or merge a PR, whatever faster :)

zickgraf commented 2 months ago

I just noticed that MonoidalCategoriesTensorProductAndUnit also spreads to other packages via the function MonoidalCategoriesTensorProductAndUnitTest, which should also be renamed.

I can do the renaming or merge a PR, whatever faster :)

It would be nice if you could to the renaming, I'm in the middle of a larger refactoring of the Add... functions with many lose ends, so my workspace is in a quite messy state right now :D

zickgraf commented 1 month ago

https://github.com/homalg-project/CAP_project/pull/1666 is incomplete because it does not rename MonoidalCategoriesTensorProductOnObjectsAndUnitObject... I can create a PR as part of a larger upcoming change.