homalg-project / CategoricalTowers

Towers of category constructors
GNU General Public License v2.0
6 stars 4 forks source link

introduce CAP quivers and their path categories #415

Closed kamalsaleh closed 11 months ago

kamalsaleh commented 12 months ago

and implement their quotient categories and linear closures

bump Algebroids to V2023.10-13

Note: Two other PR's should follow in the next two weeks: 1) Compute the data tables of linear closures of path categories or their quotients 2) Groebner basis in linear closures

kamalsaleh commented 12 months ago

I am not sure why ci fails with this error. Do you know why would that happen?

# Input is:
LoadPackage( "CatReps", false );
# Expected output:
true
# But found:
Syntax warning: Unbound global variable in /home/gap/.gap/pkg/Catego\
ricalTower\
s/Algebroids/gap/LinearClosuresOfPathCategoriesAndTheirQuotients.gi:50
    k_C := LinearClosure( k, C, sorting_func : overhead := false ); # every mo\
\
rphism start by its maximum monomial
           ^^^^^^^^^^^^^
Error, Variable: 'LinearClosure' must have a value
Error, was not in any namespace
Error, was not in any namespace

https://github.com/homalg-project/CategoricalTowers/actions/runs/6668748514/job/18125002222?pr=415

mohamed-barakat commented 12 months ago

I am not sure why ci fails with this error. Do you know why would that happen?


# Input is:

LoadPackage( "CatReps", false );

# Expected output:

true

# But found:

Syntax warning: Unbound global variable in /home/gap/.gap/pkg/Catego\

ricalTower\

s/Algebroids/gap/LinearClosuresOfPathCategoriesAndTheirQuotients.gi:50

    k_C := LinearClosure( k, C, sorting_func : overhead := false ); # every mo\

\

rphism start by its maximum monomial

           ^^^^^^^^^^^^^

Error, Variable: 'LinearClosure' must have a value

Error, was not in any namespace

Error, was not in any namespace

https://github.com/homalg-project/CategoricalTowers/actions/runs/6668748514/job/18125002222?pr=415

I will have a look.

mohamed-barakat commented 12 months ago

CatReps preloads FreydCategoriesForCAP at a point where FinSetsForCAP is not loaded yet. This causes

https://github.com/homalg-project/CAP_project/blob/532a0189964965ab821869456a9214e51b154e93/FreydCategoriesForCAP/read.g#L35-L42

not to be executed.

I will preload FinSetsForCAP before FreydCategoriesForCAP in CatReps.

mohamed-barakat commented 12 months ago

CatReps preloads FreydCategoriesForCAP at a point where FinSetsForCAP is not loaded yet. This causes

https://github.com/homalg-project/CAP_project/blob/532a0189964965ab821869456a9214e51b154e93/FreydCategoriesForCAP/read.g#L35-L42

not to be executed.

I will preload FinSetsForCAP before FreydCategoriesForCAP in CatReps.

Once https://github.com/homalg-project/CategoricalTowers/pull/416 is merged, please apply the latest PackageJanitor without https://github.com/homalg-project/PackageJanitor/pull/146, then finally rebase.

codecov[bot] commented 12 months ago

Codecov Report

Attention: 198 lines in your changes are missing coverage. Please review.

Files Coverage Δ
Algebroids/PackageInfo.g 100.00% <100.00%> (ø)
Algebroids/gap/AlgebroidFromDataTables.gi 95.51% <100.00%> (-0.02%) :arrow_down:
Algebroids/gap/GroebnerBasesForPathCategories.gd 100.00% <100.00%> (ø)
...LinearClosuresOfPathCategoriesAndTheirQuotients.gd 100.00% <100.00%> (ø)
Algebroids/init.g 94.73% <100.00%> (+1.87%) :arrow_up:
Algebroids/read.g 96.42% <100.00%> (+0.77%) :arrow_up:
Locales/PackageInfo.g 100.00% <100.00%> (ø)
Algebroids/gap/QuotientsOfPathCategories.gd 90.00% <90.00%> (ø)
Algebroids/gap/PathCategories.gd 90.90% <90.90%> (ø)
Algebroids/gap/Quivers.gd 93.10% <93.10%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

:loudspeaker: Thoughts on this report? Let us know!

mohamed-barakat commented 12 months ago

Thanks for the excellent work. Will review it during the coming days.

mohamed-barakat commented 11 months ago

Could you please rebase and re-bump the version of Locales?

mohamed-barakat commented 11 months ago

Thank you very much @kamalsaleh, wonderful work.