homalg-project / CategoricalTowers

Towers of category constructors
GNU General Public License v2.0
6 stars 4 forks source link

preload FinSetsForCAP before FreydCategoriesForCAP in tests #416

Closed mohamed-barakat closed 12 months ago

mohamed-barakat commented 12 months ago

to have the full functionality of FreydCategoriesForCAP

and before FinSetsForCAP preload CategoryConstructor (future ToolsForCategoricalTowers)

to have the full functionality of FinSetsForCAP

kamalsaleh commented 12 months ago

I think FunctorCategories and FiniteCocompletions need to be adjusted as well as both precall FreydCategories.

kamalsaleh commented 12 months ago

Note: locally when I preload FinSetsForCAP in FiniteCocompletions, the following happens:

gap> FinBouquets;
 gap> Chat := ModelingCategory( FinBouquets );
 gap> ColimitQuiversC := CategoryOfColimitQuivers( UnderlyingCategory( FinBouquets ) );
 gap> P := ColimitQuiversC.P;
 gap> b := ColimitQuiversC.b;
 Error, no method found! For debugging hints type ?Recovery from NoMethodFound
 Error, no 1st choice method found for `Limit' on 3 arguments at /home/kamal/Software/gap/lib/methsel2.g:250 called  from
Limit( H, hom_diagram[1], hom_diagram[2] 
 ) at /home/kamal/
mohamed-barakat commented 12 months ago

Note: locally when I preload FinSetsForCAP in FiniteCocompletions, the following happens:

gap> FinBouquets;
gap> Chat := ModelingCategory( FinBouquets );
gap> ColimitQuiversC := CategoryOfColimitQuivers( UnderlyingCategory( FinBouquets ) );
gap> P := ColimitQuiversC.P;

I see, this is because FinSetsForCAP is lacking the limits in CategoryConstructor (future ToolsForCategoricalTowers).

mohamed-barakat commented 12 months ago

I see, this is because FinSetsForCAP is lacking the limits in CategoryConstructor (future ToolsForCategoricalTowers).

Just forced pushed an update to this PR, please try again.

codecov[bot] commented 12 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files Coverage Δ
CatReps/PackageInfo.g 100.00% <100.00%> (ø)
FiniteCocompletions/PackageInfo.g 100.00% <100.00%> (ø)
FunctorCategories/PackageInfo.g 100.00% <100.00%> (ø)

:loudspeaker: Thoughts on this report? Let us know!.