search

homalg-project / CategoricalTowers

Towers of category constructors
GNU General Public License v2.0
6 stars 4 forks source link

Added an option to sort morphisms of externals homs in PathCategories similar to QPA #529

Closed kamalsaleh closed 6 months ago

kamalsaleh commented 6 months ago

Example:

LoadPackage( "Algebroids" );

q_string := "q(o)[x:o->o,y:o->o,z:o->o]";

C := PathCategory( FinQuiver( q_string ) : sort_external_homs_like_qpa := true );
F := FreeCategory( RightQuiver( q_string ) );

qC := C / [ [C.x^3, C.x], [C.y^3, C.y], [C.z^3, C.z], [C.xy, C.yx], [C.xz, C.zx], [C.yz, C.zy] ];
qF := F / [ [F.x^3, F.x], [F.y^3, F.y], [F.z^3, F.z], [F.xy, F.yx], [F.xz, F.zx], [F.yz, F.zy] ];

MorphismsOfExternalHom( qC.o, qC.o );
#  [ [id(o)]:(o) -≻ (o), [x]:(o) -≻ (o), [y]:(o) -≻ (o),  ..., [x^2⋅y^2⋅z^2]:(o) -≻ (o) ]
MorphismsOfExternalHom( qF.o, qF.o );
#  [ (o)-[(o)]->(o), (o)-[(x)]->(o), (o)-[(y)]->(o), ..., (o)-[(x*x*y*y*z*z)]->(o) ]

Bump FpCategories to V2024.04-01

mohamed-barakat commented 6 months ago

Thank you very much. Could you please add the above example in an example file that covers the new code? Mabye you just forgot to git add it :)

kamalsaleh commented 6 months ago

Done!

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.10%. Comparing base (7f8760c) to head (b518a1e).

Files Patch % Lines
FpCategories/gap/PathCategories.gi 92.85% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #529 +/- ## ========================================== + Coverage 76.06% 76.10% +0.04% ========================================== Files 389 389 Lines 58044 58068 +24 ========================================== + Hits 44149 44192 +43 + Misses 13895 13876 -19 ``` | [Flag](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | Coverage Δ | | |---|---|---| | [Algebroids](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `76.06% <ø> (ø)` | | | [CatReps](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `83.54% <ø> (ø)` | | | [CategoriesWithAmbientObjects](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `89.30% <ø> (ø)` | | | [ExteriorPowersCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `43.70% <ø> (ø)` | | | [FiniteCocompletions](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `92.69% <ø> (ø)` | | | [FpCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `88.43% <93.33%> (+1.47%)` | :arrow_up: | | [FunctorCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `65.47% <ø> (ø)` | | | [GradedCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `86.57% <ø> (ø)` | | | [InternalModules](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `81.66% <ø> (ø)` | | | [IntrinsicCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `82.55% <ø> (ø)` | | | [IntrinsicGradedModules](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `50.83% <ø> (ø)` | | | [IntrinsicModules](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `82.15% <ø> (ø)` | | | [LazyCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `68.12% <ø> (ø)` | | | [Locales](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `85.98% <ø> (ø)` | | | [PreSheaves](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `91.92% <ø> (ø)` | | | [QuotientCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `92.08% <ø> (ø)` | | | [SubcategoriesForCAP](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `81.25% <ø> (ø)` | | | [ToolsForCategoricalTowers](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `84.93% <ø> (ø)` | | | [Toposes](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `90.86% <ø> (ø)` | | | [ZariskiFrames](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/529/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `74.31% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mohamed-barakat commented 6 months ago

The tests took an hour longer than usual. I will restart them. In case the regression remains I will ping you.

kamalsaleh commented 6 months ago

It seems there is a problem in uploading the code-coverage:

['error'] There was an error running the uploader: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
[2024-04-11T10:18:31.615Z] ['verbose'] The error stack is: Error: Error uploading to [https://codecov.io:](https://codecov.io/) Error: There was an error fetching the storage URL during POST: 404 - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
    at main (/snapshot/repo/dist/src/index.js)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
[2024-04-11T10:18:31.615Z] ['verbose'] End of uploader: 1060 milliseconds
Codecov upload failed, retrying in 60s

I will remove the current commit and try a phantom commit to see if my code somehow causes this issue.

kamalsaleh commented 6 months ago

Uploading the code-coverage fails many times (and eventually succeeds) as expected irrelevant of my commit. It looks like a Github issue and might be resolved after few days. I have understood from Fabian that uploading the code-coverage is enabled only on gap-docker-master for pull-requests or merges; and is disabled in the gap-docker and all nighty tests. The same behaviour has been happining for few days in CAP_Project. Hence, I will re-push the original commit. It might take time until tests pass but still it can then be merged.

mohamed-barakat commented 6 months ago

Thanks for the commit and the investigation :)