Open zickgraf opened 4 months ago
Attention: Patch coverage is 84.61538%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 76.09%. Comparing base (
b313f3b
) to head (4bb1088
).
Files | Patch % | Lines |
---|---|---|
...LinearClosuresOfPathCategoriesAndTheirQuotients.gd | 60.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
by compiling
AdditiveClosure( QuotientCategory( LinearClosure ) )
@mohamed-barakat A few things:
QuotientCategory
that I am not sure for which versions the compiled code is actually valid. For loading it automatically, you can set the compiler hintprecompiled_towers
(see e.g. https://github.com/homalg-project/Algebroids/blob/277ef58afcc40ecf01d9dda51331b3f89b7f19be/gap/Algebroids.gi#L1193) in the category constructor for which the compiled code is valid.Position
, see the next point).QuotientsOfLinearClosuresOfPathCategories
sounds very specific, I guess one approach could be to first make this case more generic.