search

homalg-project / CategoricalTowers

Towers of category constructors
GNU General Public License v2.0
6 stars 4 forks source link

Fix data types in a logic template #554

Closed zickgraf closed 3 months ago

zickgraf commented 3 months ago

This is the reason for the issue described in https://github.com/homalg-project/CAP_project/pull/1634#issuecomment-2236874818.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.08%. Comparing base (8a3fba5) to head (863312e).

Files Patch % Lines
...piled_categories/FinReflexiveQuiversPrecompiled.gi 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #554 +/- ## ======================================= Coverage 76.07% 76.08% ======================================= Files 391 391 Lines 58233 58233 ======================================= + Hits 44303 44304 +1 + Misses 13930 13929 -1 ``` | [Flag](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | Coverage Δ | | |---|---|---| | [Algebroids](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `76.06% <ø> (ø)` | | | [CatReps](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `83.54% <ø> (ø)` | | | [CategoriesWithAmbientObjects](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `89.28% <ø> (ø)` | | | [ExteriorPowersCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `43.70% <ø> (ø)` | | | [FiniteCocompletions](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `92.44% <ø> (ø)` | | | [FpCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `88.43% <ø> (ø)` | | | [FunctorCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `65.37% <75.00%> (+<0.01%)` | :arrow_up: | | [GradedCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `86.57% <ø> (ø)` | | | [InternalModules](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `81.66% <ø> (ø)` | | | [IntrinsicCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `82.55% <ø> (ø)` | | | [IntrinsicGradedModules](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `50.83% <ø> (ø)` | | | [IntrinsicModules](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `82.15% <ø> (ø)` | | | [LazyCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `68.38% <ø> (ø)` | | | [Locales](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `86.00% <ø> (ø)` | | | [PreSheaves](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `89.78% <ø> (ø)` | | | [QuotientCategories](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `92.08% <ø> (ø)` | | | [SubcategoriesForCAP](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `81.25% <ø> (ø)` | | | [ToolsForCategoricalTowers](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `85.18% <ø> (ø)` | | | [Toposes](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `90.86% <ø> (ø)` | | | [ZariskiFrames](https://app.codecov.io/gh/homalg-project/CategoricalTowers/pull/554/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project) | `74.31% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=homalg-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mohamed-barakat commented 3 months ago

Do you still want to make changes before merging?