search

homalg-project / CddInterface

Gap Interface to Cdd
https://homalg-project.github.io/CddInterface
Other
1 stars 5 forks source link

Overhaul build system #19

Closed fingolfin closed 4 years ago

fingolfin commented 4 years ago

Switch to using Makefile.gappkg resp. gac to compile the kernel extension. This drops the dependencies on libtool and automake.

kamalsaleh commented 4 years ago

Thank you Max. I have tried to install the package with this commit with gap-4.11 on ubuntu 18.04 and Arch Linux 4.19.93-1-lts; in both cases autogen.sh && ./configure results the following error: configure: error: cannot find install-sh, install.sh, or shtool in cnf "."/cnf Do have any ideas how to resolve this?

fingolfin commented 4 years ago

I have an idea, will update the PR later (have to look after the kid right now). BTW I actually was hopi g that CI would verify this PR for me... But Travis is not running - I think an admin for this GitHub org (@mohamed-barakat?) needs to enable it. Alternatively we could try to set up GitHub Actions for this repo...

mohamed-barakat commented 4 years ago

I activated travis-ci.com for CddInterface and NConvex.

codecov-commenter commented 4 years ago

Codecov Report

Merging #19 into master will increase coverage by 0.43%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   89.43%   89.86%   +0.43%     
==========================================
  Files           5        5              
  Lines         861      898      +37     
==========================================
+ Hits          770      807      +37     
  Misses         91       91
Impacted Files Coverage Δ
src/CddInterface.c 95.21% <ø> (-0.10%) :arrow_down:
gap/tools.gi 82.95% <0.00%> (+0.71%) :arrow_up:
gap/polyhedra.gi 89.21% <0.00%> (+1.02%) :arrow_up:
kamalsaleh commented 4 years ago

Thank you :)