search

homalg-project / CddInterface

Gap Interface to Cdd
https://homalg-project.github.io/CddInterface
Other
1 stars 5 forks source link

Rename install.sh to prerequisites.sh #34

Open fingolfin opened 2 years ago

fingolfin commented 2 years ago

This way, GAP's BuildPackages.sh script will automatically execute it, meaning that cddlib will end up being available for more users than without this.

The GH actions CI scripts also use this, so no need for libcdd-dev anymore.

Contains PR #33. Closes PR #33

fingolfin commented 2 years ago

OK, I didn't realize it, but this is missing code in configure.ac which checks if prerequisites.sh was run and a working "local" cddlib is present, and if so, uses that automatically, unless the user explicitly specifies --with-cddlib=PATH (similar to what is in NormalizInterface).

And perhaps prerequisites.sh should also check if cddlib is already available, and in that case, do nothing. But doing that in a way that matches the behavior of configure.ac exactly (to avoid situations where prerequisites.sh detects a present cddlib but then configure.ac does not detect it) could be tricky. Ah well.